Make All Lights the LED chain instead of a partition over the zones - #23
Merged
Conversation
#21 built All Lights as a partition over the five zone lights, which wraps each zone in an AddressableLightWrapper. That wrapper refuses to write a zone whose own state is on, so All Lights could only drive zones that were already off, and it reports one pixel per wrapped light, so effects on it rendered as five blocks rather than a 37 pixel pattern. All 37 LEDs sit on one chain on GPIO3, so the chain itself is the all-lights light. Drop internal: true, name it All Lights, point the five zone partitions at it, and delete the master block. color_correct goes with it. Partitions substitute their own correction for every pixel they write and nothing ever wrote through the chain, so the 40% never reached an LED. Keeping it would cap All Lights alone at 40% while the zones stayed at 100%. Version 26.8.28.1 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.8.28.1
What does this implement/fix?
#21 built
All Lightsas a partition over the five zone lights, which wraps each zone in anAddressableLightWrapper. That wrapper refuses to write a zone whose own state is on, so All Lights can only drive zones that are already off. Turn on Body Light, then turn All Lights off, and the body stays lit. It also reports one pixel per wrapped light, so All Lights is a five pixel strip and an effect on it renders as five blocks rather than a 37 pixel pattern.The wrapping was never needed. All 37 LEDs sit on one chain on GPIO3, so the chain already is the all-lights light. This drops
internal: truefrom it, names itAll Lights, points the five zone partitions at it, and deletes the master block. Effects on a zone are unchanged, and effects on All Lights now address the real 37 pixels, so the index-driven ones (RainbowWave,Sandstorm) render as one pattern across the ornament instead of five copies.color_correct: [40%, 40%, 40%]goes with it. Partitions substitute their own correction for every pixel they write, so the chain's value never applied to a zone, and nothing ever wrote through the chain itself. The 40% has never reached an LED on any build. Keeping the line would newly cap All Lights alone at 40% while the five zones stayed at 100%.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
esphome configpasses on bothH-3.yamlandH-3D.yamlagainst esphome 2026.8.1. Flashed to hardware over COM5 and running.🤖 Generated with Claude Code